My first Pull Request

-
For the next lab for my Open Source class, the goal is to create a repository with a simple open source library, let other students contribute to my library, while I got the chance to contribute to their repositories. The library is meant to get simple file information, such as file name, file size, and sha1/MD5 digest. I decided to write my library in JavaScript. I created four empty functions, raises 4 issues, and then waited for someone else to create a pull request against my code. Lately I was the one that would go into different Git project, look through all the issues to find the good first issue label. It was a nice change to create these issues myself, and then place labels on them.



Eventually another student changed some of my code sent a pull request. I accepted it and merged his code together with him. I closed one of my issues, maybe someone else will come and help me out with the others.



Now I had to contribute to another student's project. I knew the basics of Git, how to clone a repository to my local machine, pulling, pushing. I never understood the concept of pull request, or how to do one. I previously tried submitting a pull request but I was always afraid that I would mess something up. This was the perfect opportunity for me to create my first pull request because this is a lab intended just for this, there is no way I can mess this up. I decided to go with feihaozi77's project BuildingJSLibrary. Feihaozi77 had 2 issues raised, one for an MD5 digest, and the other for a sha1 digest. I forked the project, cloned it to my local machine, and started working away on it. Once I had code that was working properly, I pushed it to my GitHub then created a Pull request for my issue. Creating the Pull request was much simpler then I thought! I had to select two branches to compare, I used my branch against the master, and I created the Pull request.


The author had some troubles running the code, I think my instructions weren't very clear. Let's hope the author accepts the pull request now after clearing it up!




I feel that with this lab complete, I learned a lot more about Git. I learned how to create and accept a Pull request, how to raise issues, what is a fork. I now feel comfortable working on larger projects and contributing to them.

Comments

Post a Comment

Popular posts from this blog

DPS911 - Release 3

-
Image
This is my third release for my Open Source class. This release is a progression on my the second release , where I used WebTorrent for sharing resource files. In the previous release, I created two different pages, one for importing files and one is exporting files. With this release, I joined the two files together, and added a few new features, such as number of peers, and download progression.    For testing purposes, we have a temporary main page for testing things like the editor, the Linux terminal, or file editor. I've added the share link in there as well for easy access during testing.  The look of the page is elegant now, it looks professional compared to the previous iteration. It displays the progress of the download, remaining time, download speed, download progress, upload speed, number of peers, and the total time. Once the torrent is complete, a message pop ups on the bottom saying it is complete. To start the torrent, the Start Seed button needs t
Read more

DPS911 - Release 1

-
Image
About two weeks ago, I started a DPS911 Open Source Projects class, which is essentially a continuation of the previous DPS909 Topics in Open Source Development class that I took last year. The class size is much smaller, we have 4 students compared to the 30+ we had last time, which is nice the professor can spend more time with us as opposed to the entire 30+ class of students. For this class, we are starting a project that my professor has envisioned, for now we are calling it unbundled . This project is meant to recreate an operating system for web development in a browser environment. The idea is to have features such as accessing directory of files, a code editor, command line terminal, sharing files, and more, be available in the browser for use on any operating system. The project isn't re-inventing the wheel, the technology is already there, we are just putting everything together. Brackets , for example, will be used for the code editor, while webtorrent will be used f
Read more

DPS911 - Release 2

-
Image
This is my second release for the DPS911 - Open Source class. With this release, I created two pages for sharing resource files between users, one was for importing the files, and the other was for exporting. I am using Webtorrent streaming service for sharing the files. The pull request can be found here , while the issue is located here I did have some trouble with this release. Initially, I had the user selecting local files to share instead of resource files. The pages themselves are very simple, most of the work was done in the back-end. The import page only has an input field for the magnetURI, and a download button download all the files. The export page automatically starts the torrent when opened, sharing all of the resource files, and displaying the magnetURI. This release was simple, there's no extra features included such as number of seeders, progress, or number of files. All this will be included in the next release, which will include combining the pages into
Read more